supabase / supabase-flutter / 31086976506

89%

Build Type

push

github

Committed by web-flow

Commit Message

fix(supabase_lints): enable lines_longer_than_80_chars and fix all violations (#1655)

## Why

`dart format` never reflows comments and never splits string literals,
so nothing enforced the 80-column limit outside of the code the
formatter can break by itself. 440 over-long lines had accumulated
across 109 files, and CodeRabbit was doing the enforcement by hand in
review (it flagged two such lines on #1654).

Enabling the rule continues the ratcheting pattern
`packages/supabase_lints/lib/analysis_options.yaml` already documents:
turn a rule on once its violations are gone.

## What

`lines_longer_than_80_chars: true` in the shared lint config (the
Flutter variant includes it, so both are covered), plus the 440 fixes.

| Category | Count | Treatment |
| --- | --- | --- |
| Prose in `///` / `//` blocks | 281 + 59 | Rewrapped at 80 columns,
wording unchanged |
| Over-long string literals | ~100 | Split into adjacent literals (same
value) |
| Doc code samples | 12 | Reformatted the way `dart format` would break
the same code |
| Missing space after `///` / `//` | 4 | Added, then wrapped |
| Other | 4 | See below |

The four one-offs:

- `buildClientInfoHeader` computes the encoded platform version into a
local instead of interpolating a call chain that cannot fit on one line.
Same output.
- Two `test(...)` headers with a trailing closure moved their arguments
onto separate lines.
- One trailing `// comment` on a map entry moved above the entry.

Three doc samples were JavaScript left over from the ports (`new
RetryTimer(...)`, `console.log(...)`, `let`) inside ` ```dart ` fences.
They are Dart now.

Fenced code, markdown lists and tables, and `{@template}` macros were
kept structurally intact rather than reflowed as prose.

## String values are provably unchanged

Splitting a literal into adjacent literals is value-preserving only if
the split points are the sole change, so that was checked mechanically
rather than by eye: every string literal value in ev... (continued)

Coverage Stats

53 of 64 new or added lines in 20 files covered. (82.81%)

5 existing lines in 3 files now uncovered.

5618 of 6451 relevant lines covered (87.09%)

4.02 hits per line