visgl / deck.gl / 31062458629

84%

push

github

fix(mapbox,google-maps): use css-dpr pixel sizing in overlaid mode to prevent basemap misalignment (#10370)

* fix(mapbox,google-maps): use css-dpr pixel sizing in overlaid mode to prevent basemap misalignment

At fractional browser zoom levels, luma.gl's exact device-pixel-content-box sizing
diverges from the Math.round(css * dpr) approach used by Mapbox GL, MapLibre, and
Google Maps, causing visible drift between the deck.gl overlay canvas and the basemap.

Pass pixelSizeSource: 'css-dpr' when creating the canvas context in overlaid (non-interleaved)
mode so luma.gl derives pixel sizes using the same rounding as the underlying basemap.

Depends on visgl/luma.gl#2588 (pixelSizeSource prop, merged to master, pending release).

Closes #10173

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(mapbox): add ts-expect-error for pixelSizeSource pending luma.gl release

The pixelSizeSource prop is available in luma.gl >9.3.3 (visgl/luma.gl#2588)
but not yet in the currently pinned @luma.gl/core@9.3.3 types.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: bump @luma.gl to 9.3.4 and remove ts-expect-error workaround

luma.gl 9.3.4 ships the pixelSizeSource prop (visgl/luma.gl#2588),
so the ts-expect-error suppression is no longer needed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: bump @luma.gl to 9.3.5 and add fractional-zoom test app

- Update yarn.lock to pull in @luma.gl/core 9.3.5 which includes the
  css-dpr observer box fix (visgl/luma.gl#2676)
- Add test/apps/fractional-zoom-alignment for manual verification of
  issue #10173 (basemap misalignment at fractional browser zoom)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test(mapbox,google-maps): verify pixelSizeSource css-dpr in overlaid mode

Add unit tests confirming that MapboxOverlay and GoogleMapsOverlay pass
pixelSizeSource: 'css-dpr' through deviceProps.createCanvasContext when
creating their own Deck instance, ensuring the lum... (continued)

8389 of 10509 branches covered (79.83%)

Branch coverage included in aggregate %.

14765 of 17137 relevant lines covered (86.16%)

18805.15 hits per line