medplum / medplum / 31060324972

92%

Build Type

push

github

Committed by web-flow

Commit Message

Guard against WebSocket subscription messages without a SubscriptionStatus (#10062)

* Guard against WebSocket subscription messages without a SubscriptionStatus

The SubscriptionManager message handler read bundle?.entry?.[0]?.resource
with optional chaining but dereferenced .type on it unguarded, so any
parseable frame without a SubscriptionStatus threw
"Cannot read properties of undefined (reading 'type')" and the catch
broadcast the TypeError as an error event to every criteria emitter
(likely the Sentry noise reported in #6590).

Warn and ignore such frames instead, matching the handler's existing
treatment of notifications for unknown subscriptions. Unparseable frames
still surface through the catch as error events.

Signed-off-by: Albert Wong <183894628+ajwwong@users.noreply.github.com>

* [autofix.ci] apply automated fixes

* Include the parsed payload in the dropped-frame warning

Per review: log the received message alongside the warning for
auditability. Test asserts the payload is passed for both malformed
shapes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Albert Wong <183894628+ajwwong@users.noreply.github.com>

---------

Signed-off-by: Albert Wong <183894628+ajwwong@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Coverage Stats

22985 of 26078 branches covered (88.14%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

6 existing lines in 2 files now uncovered.

40754 of 43155 relevant lines covered (94.44%)

12210.87 hits per line