dangernoodle-io / breadboard / 31060892366

97%

push

github

fix: stop kind-excluded bb_data_http clients from participating in mismatched machinery (B1-1446) (#1235)

B1-1445 gated STATE/EVENT delivery only via client_subscribes()'s mask check -- a kind-excluded client was still visited by every loop and merely filtered at the end. This closes that gap with three skips:

- drain_client_events() is now skipped entirely for a mask-excludes-EVENT client -- the real, previously-absent non-participation gap: that function unconditionally advanced event_cursor/drop-accounting off the shared ring's own state regardless of any per-entry client_subscribes() filtering inside it. Proven by a mutation test that fails with "Expected 0 Was 3" when the skip is reverted.

- the acquire-time force-dirty walk and the sweep's STATE-detect inner client loop now hoist their subscribe_mask check to once per client. client_subscribes() already ANDs this same bit (B1-1445), so this produces no new observable behavior today -- it is a prerequisite for B1-1447, which splits STATE bookkeeping into a poll pointer that is NULL for a mask-excludes-STATE client; visiting these loops at all for such a client would then be a NULL dereference. The rewritten test (renamed from a non-participation claim it couldn't back up) is now an honest delivery-gate regression guard for B1-1445's existing behavior instead.

client_subscribes()'s own mask-mismatch branch is now unreachable given every call site pre-filters on the same bit, so it's marked LCOV_EXCL_BR_LINE as defense-in-depth rather than deleted.


Claude-Session: https://claude.ai/code/session_0119nuE2NZME9y2aYEVJTPB5

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

8474 of 9014 branches covered (94.01%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 1 file covered. (100.0%)

14204 of 14359 relevant lines covered (98.92%)

2615.16 hits per line