UI5 / cli / 31038472951

94%

push

github

fix(server): Clone custom middleware configuration before passing it

The middlewareDef.configuration object is a reference to the same project
configuration used elsewhere to read the project's config. Passing the
reference directly allowed custom middlewares to mutate it.

This notably affected the build cache: most of the ui5.yaml configuration
is part of the cache signature, so a mutated projectConfig could differ
between a build run on the server and a regular build, which must not
happen. Cloning the configuration here isolates custom middlewares from
the shared object and prevents similar issues elsewhere.

7233 of 7969 branches covered (90.76%)

Branch coverage included in aggregate %.

13857 of 14443 relevant lines covered (95.94%)

5304.33 hits per line