mozilla-releng / balrog / #5715

90%

push

circleci

fix: ensure compat check for avast only applies when query key is exactly "avast"

The "?avast=1" workaround only checked that "avast" appeared somewhere
in the force value, not that the injected key was actually "avast".
An unauthenticated client could put "avast" before the "?" to satisfy
that check while injecting any query key as an int (e.g.
force=1avast?locale=1), causing an exception.

Bug: 2060818

2189 of 2576 branches covered (84.98%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

5771 of 6301 relevant lines covered (91.59%)

0.92 hits per line