kubevirt / containerized-data-importer / #6165

50%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

Add certificate validation support for VDDK importer (#3947)

* Add certificate validation support for VDDK importer

- Add CertConfigMap field to DataVolumeSourceVDDK API (already in types.go)
- Update UpdateVDDKAnnotations to copy CertConfigMap to PVC annotations
- Reuse existing createCertPool function from http-datasource.go instead of duplicating logic
- Modify createVMwareClient to accept certDir and insecureTLS parameters
- Update VDDK data source to use certificates when provided
- Update importer entry point to pass certDir and insecureTLS
- Update architecture stubs and tests to match new signatures
- Update documentation to include certConfigMap field

This enables secure TLS connections to VMware vCenter/ESXi when
certificates are provided via ConfigMap, while maintaining backward
compatibility with insecure connections when needed.

Signed-off-by: gcasey <gcasey@redhat.com>

* Add certConfigMap to OpenAPI/CRD schemas and update VDDK docs

Signed-off-by: Gwen Casey <gcasey@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* Refactor createVMwareClient to use config struct (fix SonarCloud S107)

Signed-off-by: Gwen Casey <gcasey@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix SonarCloud S107: refactor VDDK and test helpers to use config structs

- Add VDDKDataSourceConfig and refactor NewVDDKDataSource/createVddkDataSource
- Add VDDKImportParams and refactor NewDataVolumeWithVddkImportAndCertConfigMap
- Update arm64/s390x stubs, importer cmd, and tests

Signed-off-by: Gwen Casey <gcasey@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* Regenerate OpenAPI swagger with certConfigMap in DataVolumeSourceVDDK

Align api/openapi-spec/swagger.json with codegen from staging API types
so that make generate-verify passes.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Gwen Casey <gcasey@redhat.com>

* bazel: add vddk-datasource.go to pkg/importer BUILD.bazel

Co-authored-by: Cursor <cursorag... (continued)

Coverage Stats

39 of 76 new or added lines in 3 files covered. (51.32%)

11 existing lines in 2 files now uncovered.

15151 of 30458 relevant lines covered (49.74%)

0.56 hits per line