decentraland / marketplace-server / 31034531692

62%

main: 62%

Pull #385

github

fix: date an item by its first listing, not its most recent one

The item-unified grid hides resales (the Shop sends listingType=primary while
the secondary-sales flag is off), and listingType is applied per branch, before
the union — so the per-item window only ever sees primary rows. Taking MAX there
was justified by a resale case that cannot occur, and it left the two halves of
the sort inconsistent: store rows carry first_listed_at, which never bumps,
while trade rows moved every time a new listing was signed.

MIN makes the whole key mean one thing — when the item first became buyable —
matching both the store branch and the marketplace's CatalogSortBy.NEWEST, whose
item_first_listed_at is likewise a MIN over primary trades. Taking the latest is
RECENTLY_LISTED there, a separate sort, and would let an item that has been
minting for months jump to the front of the grid on a second listing. Renamed to
item_first_listed_at to match that vocabulary.

Cancelled and sold-out listings leave mv_trades' open set, so a plain re-list
still surfaces as new under either aggregate; the two differ only for an item
with several concurrently-open primary offers.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

1657 of 3104 branches covered (53.38%)

Branch coverage included in aggregate %.

3018 of 4477 relevant lines covered (67.41%)

26.19 hits per line