mnasyrov / nrgy / 31027435545

99%

main: 99%

push

github

fix: invalid hook call in useController() under React.StrictMode

The remount cycle of StrictMode recreates the controller inside
useEffect(), and createHookContext() invoked the extension providers
there. Providers may call React hooks (like the provider of
@nrgyjs/ditox-react), so the recreation failed with 'Invalid hook
call' because the hooks were invoked outside of rendering.

Now the providers are invoked in the body of useController() on every
render, and the controller is constructed with the captured extension
params via provideExtensionParams(). It also makes the HACK branch
with the compensating invocation of the providers unneeded.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

243 of 247 branches covered (98.38%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

661 of 663 relevant lines covered (99.7%)

6009.71 hits per line