bleedingdeacons / concordance / 31016175798

94%

Build Type

push

github

Committed by web-flow

Commit Message

chore(tooling): make PSR-12 a gate and badge the standard (#30)

PHPCS has been running advisory since it was added, with a note to promote
it once the repo was green. It never was, but most findings turned out to be
either a WordPress requirement, a test-only idiom, or whitespace phpcbf
fixes on its own.

Exclude the first two groups in .phpcs.xml.dist, each with the reason:

- Generic.Files.LineEndings — git normalises to LF in the index, so this
  only ever fired on Windows working copies, never in CI.
- Generic.Files.LineLength — PSR-12's 120-char limit, against markup and
  option literals where wrapping reads worse.
- PSR1.Files.SideEffects — the mandatory `if (!defined('ABSPATH')) exit;`
  guard counts as a side effect next to the class declaration.
- PSR1.Methods.CamelCapsMethodName, PSR1.Classes.ClassDeclaration,
  Squiz.Classes.ValidClassName, PSR12.Files.FileHeader — scoped to tests/,
  where snake_case BDD names and global WP_* stubs are deliberate.

CamelCapsMethodName is also excluded for src/Cli, for a different reason:
ConcordanceCli extends WP_CLI_Command, where a public method name *is* the
subcommand name. Renaming list_groups and flush_cache to camelCase would
rename `wp concordance list_groups`, so they stay as they are.

Two things needed hands.

Container.php declared three classes: Container plus NotFoundException and
ContainerException. The two exceptions move to their own PSR-4 files in the
same namespace, so nothing that referenced them by name had to change, and
Container.php drops the two `use` statements it no longer needs.

SettingsAdmin.php had a multi-line esc_html_e() spanning inline HTML where
PSR2's call-signature sniff wanted 8 spaces and PSR-12's scope-indent sniff
wanted at least 11 — a conflict no indentation satisfies, and the reason
phpcbf could not converge on this file. Collapsing the call to one line, as
the surrounding template already does elsewhere, removes the conflict. A
nonce check on the same file lo... (continued)

Coverage Stats

4 of 6 new or added lines in 3 files covered. (66.67%)

1 existing line in 1 file now uncovered.

1195 of 1253 relevant lines covered (95.37%)

7.01 hits per line