pulibrary / tigerdata-app / 1455429a-28ff-4078-8668-55103f1ccca4

94%

main: 94%

Pull #2829

circleci

Fix dashboard table accessibility, HTML structure, and DataTables bundler integration

This commit resolves dashboard table HTML violations and fixes DataTables initialization failures caused by Vite/ESM bundler transformations, ensuring robust accessibility (a11y) compliance and stable test coverage.

Key Changes:
- Resolve HTML/accessibility compliance issues in dashboard project and request listings:
  - Add explicit scope='col' attributes to all table headers (<th>).
  - Fix a broken HTML tag syntax error where the 'type' header used an opening <th> but closed with </td>.
  - Remove the invalid role='rowheader' attribute from the table header row (<tr>).
- Fix DataTables plugin loading in Vite/ESM environments (app/javascript/entrypoints/pulDataTables.js):
  - Import jquery and datatablesFactory, programmatically registering DataTables on the module's jQuery instance to circumvent UMD/ESM binding issues.
  - Implement length and isDataTable checks to avoid re-initialization errors and allow graceful no-ops.
  - Set DataTables translation format to: info: '_START_ - _END_ out of _TOTAL_ shown'.
- Introduce a comprehensive Vitest unit test suite (app/javascript/tests/pulDataTables.test.js) to verify DataTables registration, pagination boundaries, info strings, and empty state handling.
- Explicitly target global window functions (window.setupTable, window.dashStyle, etc.) in dashboard index.html.erb.
- Update spec/system/dashboard_spec.rb to assert on the new info text format using scoped CSS selectors with a regex match.

0 of 314 branches covered (0.0%)

3310 of 3538 relevant lines covered (93.56%)

618.02 hits per line