bleedingdeacons / amber / 31012108791
92%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 30
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.85% (-0.2%) from 93.083%
31012108791

push

github

web-flow 
chore(tooling): make PSR-12 a gate and badge the standard (#42)

PHPCS has been running advisory since it was added, with a note to promote
it once the repo was green. It never was: 681 findings, but 673 of them were
either a WordPress requirement, a test-only idiom, or whitespace phpcbf
fixes on its own.

Exclude the first two groups in .phpcs.xml.dist, each with the reason:

- Generic.Files.LineEndings — .gitattributes normalises to LF in the index,
  so this only ever fired on Windows working copies, never in CI.
- Generic.Files.LineLength — PSR-12's 120-char limit, against shortcode HTML
  and option literals where wrapping reads worse.
- PSR1.Files.SideEffects — the mandatory `if (!defined('ABSPATH')) exit;`
  guard counts as a side effect next to the class declaration.
- PSR1.Methods.CamelCapsMethodName, PSR1.Classes.ClassDeclaration,
  Squiz.Classes.ValidClassName, PSR12.Files.FileHeader — scoped to tests/,
  where snake_case BDD names and global WP_* stubs are deliberate.

phpcbf then handled the whitespace: opening braces onto their own line,
inline `if (...) { return $x; }` expanded, trailing blank lines before
closing braces dropped. No behaviour changes — `git diff -w` is empty for
most of the 23 files touched.

Two needed hands. GeneralShortcodes and HtmlHelper each had a docblock that
PHPCS read as a file-level docblock, because a `class_exists()` guard sits
between it and the class it documents. Moving each docblock inside its guard,
directly above the class, satisfies PSR-12 and makes it a real class docblock
that IDEs will now pick up.

With that the repo is clean, so PHPCS moves out of the advisory block and
becomes a gate.

The README badge reads the standard out of .phpcs.xml.dist via shields'
dynamic/xml rather than hardcoding it, matching what the PHPStan badge does
with phpstan.neon.dist. A CI step asserts the XPath still resolves, the same
guard the PHPStan badge already has.

3623 of 3902 relevant lines covered (92.85%)

3.8 hits per line

Coverage Regressions

Lines Coverage ∆ File
24
92.75
-0.68% amber/amber/src/Admin/IntergroupMeetings/IntergroupMeetingAdmin.php
10
94.98
-1.1% amber/amber/src/Admin/Positions/PositionAdmin.php
8
93.51
-1.86% amber/amber/src/Admin/IntergroupMeetings/IntergroupMeetingDashboard.php
5
91.41
0.0% amber/amber/src/Admin/Meetings/MeetingAdmin.php
1
97.72
-0.31% amber/amber/src/Admin/Members/MemberAdmin.php
1
93.55
0.0% amber/amber/src/Managers/IntergroupManager.php
1
73.11
0.0% amber/amber/src/Shortcodes/GeneralShortcodes.php
1
96.67
0.0% amber/amber/src/Utils/HtmlHelper.php
Jobs
ID Job ID Ran Files Coverage
1 31012108791.1 30
92.85
GitHub Action Run
Source Files on build 31012108791