NOUIY / thumbor / 31001653605

89%

push

github

feat: parse the Accept header instead of searching substrings

RequestParameters now parses the Accept header into media ranges with
quality values, handling quoted parameters, whitespace and case. It
exposes accepts_avif, accepts_heif, accepts_png and accepts_jpeg next
to the existing accepts_webp, and accepts_mime_type answers from the
parsed values.

Three behavior changes, all on purpose:

- A format listed with q=0 is rejected. Before, image/webp;q=0 still
  counted as accepting WebP because only the substring was checked.
- image/* accepts every image format. Before it matched nothing.
- */* keeps its old meaning: it only enables JPEG, never the other
  formats, so existing AUTO_WEBP deployments keep the same behavior.

New keyword arguments were appended after the existing ones, so callers
that pass positional arguments keep working. Handlers that build their
own request objects keep the old substring lookup.

Co-authored-by: Pablo Santiago Blum de Aguiar <scorphus@gmail.com>

74 of 83 new or added lines in 2 files covered. (89.16%)

4010 of 4509 relevant lines covered (88.93%)

4.45 hits per line