supabase / supabase-swift / 30998461998

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix: flaky CI in AuthTests and RealtimeTests (#1164)

* fix(realtime): buffer early push ack to avoid lost-ack timeout

An ack arriving before send() registered its continuation was silently
dropped, forcing the push to wait out the full timeout. Under CI load
this lost race often enough to flake pushWithAck().

* test(auth): stop mutating the shared jsonEncoder singleton

Several suites grabbed AuthClient.Configuration.jsonEncoder (a
process-wide singleton) and mutated its outputFormatting in place, an
unsynchronized data race under Swift Testing's default parallel
execution. Each makeSUT() now builds its own encoder instead.

* fix(test): retry transient storage-api 500s in StorageFileIntegrationTests

storage-api occasionally returns a transient 500 ("Internal Server Error" /
"No such file or directory") on an operation immediately following an
upload() in CI — an eventual-consistency race in the backend, not an SDK
bug. Confirmed recurring across different operations (moveObjectToDifferentPath,
signURL_withCustomFilenameForDownload) in prior CI runs on main.

* fix(test): serialize withMainSerialExecutor across suites and targets

withMainSerialExecutor (ConcurrencyExtras) mutates a process-global
scheduling flag with no scoping guarantee if it changes mid-operation
(their own doc warns of this). `.serialized` only serializes a suite's
own tests, not against other suites running concurrently, so any two
suites calling withMainSerialExecutor at the same time can stomp each
other's save/restore — this caused a cascade of ~19 spurious failures
(sessionMissing, MockNotFound, 78s hangs) across AuthClientTests,
AuthOAuthServerTests, RequestsTests, and SessionManagerTests in one CI run.

Add a MainSerialExecutorGate (mirrors the existing MockerGate/
.mockerSerialized pattern) and apply .mainSerialExecutorSerialized to
every suite that calls withMainSerialExecutor.

* Revert "fix(test): retry transient storage-api 500s in StorageFileIntegrationTests"

Thi... (continued)

Coverage Stats

12 of 14 new or added lines in 1 file covered. (85.71%)

21 existing lines in 1 file now uncovered.

8440 of 10061 relevant lines covered (83.89%)

1067271.25 hits per line