adaptive-machine-learning / CapyMOA / 30972516188

80%

Build Type

push

github

Committed by hmgomes

Commit Message

fix(drift): validate the DriftStream definition up front

Raised in review of #372: malformed definitions still produced silently
wrong streams.

    [generator, AbruptDrift(...)]                 -> get_num_drifts() == 1,
                                                     no drift in the CLI
    [generator, drift1, drift2, generator]        -> get_num_drifts() == 2,
                                                     only the last composed

The builder appends each Drift to self.drifts as it encounters it, before
it knows whether a concept follows, so a list that does not alternate
reports drifts that were never composed. The stream then behaves
differently from what it advertises.

The definition is now checked before anything is composed: it must be
non-empty and alternate concept, drift, concept, ... starting and ending
with a concept. Each failure names the offending position.

This replaces the inline unsupported-component guard from the previous
commit, which the pre-pass now covers, so there is one place that decides
what a valid definition is.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

28 of 28 new or added lines in 2 files covered. (100.0%)

22 existing lines in 2 files now uncovered.

7842 of 10149 relevant lines covered (77.27%)

0.77 hits per line