AfterShip / clickhouse-sql-parser / 30969327660

56%

Build Type

push

github

Committed by web-flow

Commit Message

Add support for ALTER TABLE ... MODIFY ORDER BY (#303)

MODIFY ORDER BY replaces the sorting key of a MergeTree table, as in
ALTER TABLE flows MODIFY ORDER BY (TimeReceived, ExporterAddress). The
new AlterTableModifyOrderBy clause follows the shape of the other MODIFY
clauses and holds the key as a single expression.

A single expression (as a tuple) is used rather than an order by list:
inside an ALTER a comma starts the next clause, so a key over several
columns is written as a tuple and reusing parseOrderByClause would
swallow the following clause.

The code is different than for CREATE TABLE, as this one accepts ORDER
BY a DESC. However, it should require an expression (a tuple for
multiple columns). This will be fixed in the next commit.

Checked against clickhouse-local 26.2.5.

Coverage Stats

30 of 61 new or added lines in 6 files covered. (49.18%)

2224 existing lines in 6 files now uncovered.

9254 of 16763 relevant lines covered (55.2%)

3741.56 hits per line