kubeflow / sdk / 30952210986

86%

push

github

fix(spark): align Spark Connect service-name fallback with operator default (#518)

* fix(spark): rely on operator-reported service name for in-cluster URL

build_service_url uses Status.Server.ServiceName directly (correct for both the operator default <name>-server and user-customized Service names) and raises if it is not yet populated, instead of guessing a name. get_connect_url port-forwards only to the reported service or driver pod and raises if neither is populated. Tests cover the default and custom service-name cases and the not-ready raise paths.

Signed-off-by: Kartikeya Trivedi <kartikeyatrivedi4oct2004@gmail.com>

* test(spark): fold get_connect_url not-ready case into parameterized test

Address review: move the standalone no-port-forward-target test into the existing pytest TestCase parameterization used across the project.

Signed-off-by: Kartikeya Trivedi <kartikeyatrivedi4oct2004@gmail.com>

---------

Signed-off-by: Kartikeya Trivedi <kartikeyatrivedi4oct2004@gmail.com>

16 of 16 new or added lines in 4 files covered. (100.0%)

6179 of 7251 relevant lines covered (85.22%)

1.7 hits per line