bleedingdeacons / concordance / 30949935628

94%

push

github

test(admin): cover src/Admin and drop its coverage exclusion (#26)

src/Admin was excluded from the coverage source set as "WordPress admin
render/menu/AJAX glue exercised through the admin UI at runtime". Amber
covers its whole src/Admin on this same tooling, so the exclusion was
habit rather than necessity — and here it hid the API-client wiring
behind both admin screens: the settings page's intergroup dropdown is
built from whatever ApiCache last returned, and the API key round-trips
through Encryption on the way in and out of wp_options.

117 new tests across SettingsAdmin (68) and GroupListingDashboard (49),
following integrity#42: registration methods run for real against
WpState, capability guards assert on the WpDieException/
JsonResponseException the shared stubs throw, and render methods are
driven inside an output buffer and asserted on their HTML. ApiClient and
ApiCache are doubles throughout, so nothing reaches the network.

Two production extractions, both behaviour-identical, both for the same
reason: wp_redirect() is recorded by the stubs rather than thrown, so
"redirect then exit" would take PHPUnit down with it.

  - SettingsAdmin::resolveCacheFlushRedirect() takes over
    handleCacheFlush()'s branching and answers with a URL, or null for
    the two cases that leave the request alone. handleCacheFlush() is
    now the redirect and the exit.
  - GroupListingDashboard::applySetIntergroup() takes over the option
    write and referer resolution at the tail of handleSetIntergroup().

Both are private and reached from the tests by reflection.

The <exclude> block in phpunit.xml is replaced by a comment explaining
why nothing is excluded, so the next person does not reinstate it.

17 of 21 new or added lines in 2 files covered. (80.95%)

1196 of 1252 relevant lines covered (95.53%)

7.05 hits per line