lsm / HyperNeo / 30947090055

40%

Build Type

push

github

Committed by web-flow

Commit Message

feat(space): split Reviewer/Merger roles + shell-less Reviewer (Option C) [#836] (#2365)

* feat(space): post_review node-agent tool for shell-free review posting

Adds a `post_review` MCP tool so the Reviewer can post GitHub PR reviews
(APPROVE/REQUEST_CHANGES/COMMENT) with anchored line comments without a
shell — the daemon calls the GitHub REST API via `gh` server-side, on the
same credential path as the github connector / pr_ready validator.

- post-review-handler.ts: pure orchestration (payload construction +
  automatic own-PR fallback APPROVE/REQUEST_CHANGES -> COMMENT) with injected
  deps for unit-testability; buildGhPostReviewDeps wires the real `gh` spawn.
- node-agent-tool-schemas/node-agent-tools: register the tool, gated on an
  onPostReview callback.
- task-agent-manager: provide onPostReview for reviewer sessions only
  (detected by handle/templateName), resolving the PR URL + head SHA.

Part of Task #836 (Reviewer/Merger role split, Option C).

* feat(space): split Reviewer/Merger roles — dedicated merge agent, shell-less Reviewer (Option C)

Isolates all code execution onto a dedicated PR Merger and makes the Reviewer
a pure static-review role with no shell.

- seed-agents: new "PR Merger" preset (Bash + read tools — the designated
  execution agent). REVIEWER_TOOLS drops Bash entirely; the Reviewer posts
  reviews via post_review, enforced at the tool level. (post_review is an MCP
  tool, so it is intentionally absent from the profile — the profile only
  accepts KNOWN_TOOLS SDK built-ins, and MCP tools are inherited regardless of
  the profile per DENIABLE_TOOLS.)
- built-in-workflows: retarget the three postApproval routes
  (Coding / Research / Fullstack-QA) from `reviewer` to `merger`, and add a
  dedicated "Post-Approval" node to each graph whose slot is the merger. The
  node has no channels and is never activated by normal flow, so the merger
  only spawns via spawnPostApprovalSubSession after approval (it does not
  auto-spa... (continued)

Coverage Stats

19034 of 54342 branches covered (35.03%)

Branch coverage included in aggregate %.

11 of 81 new or added lines in 6 files covered. (13.58%)

1 existing line in 1 file now uncovered.

28657 of 64911 relevant lines covered (44.15%)

276.56 hits per line