ginkgobioworks / react-json-schema-form-builder / 30931697853

73%

push

github

Do not start a drag when a gesture begins in an interactive element

@dnd-kit's listeners are spread over the whole sortable item in
SortableItem, and no activator node is set, so every pointerdown and
keydown inside a form element card reaches the sensors:

- PointerSensor starts a pending drag for a press inside a text field.
  Once the 8px activation distance is travelled, AbstractPointerSensor
  clears the document selection and keeps clearing it on selectionchange,
  so text cannot be selected with the mouse and the card drags instead.
- KeyboardSensor skips its "event target must be the activator node"
  guard when there is no activator node, so pressing Space or Enter in a
  card's input starts a keyboard drag and is preventDefault()ed instead
  of typing a space or activating the focused button.

Wrap both sensors so their activators bail out when the gesture starts in
an interactive element. Dragging a card from anywhere else, including its
header and body, is unchanged.

Fixes #685

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

801 of 1136 branches covered (70.51%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

901 of 1205 relevant lines covered (74.77%)

22.78 hits per line