FAIRmat-NFDI / nomad-parser-plugins-simulation / 30922399797

77%

push

github

Add scf annotation (#181)

* Add SCF convergence criteria mapping for FHI-aims

Add SelfConsistency annotation using multi-mapper pattern to extract
convergence criteria (energy, density, eigenvalues) as separate instances
alongside KSpace in DFT.numerical_settings.

Changes:
- Add convergence quantity parsers to out_parser.py
- Implement get_scf_convergence_criteria() to transform parsed data
- Add SelfConsistency.m_def annotation with function transformer
- Add test case for multi-instance convergence criteria

Depends on multi-mapper infrastructure in nomad-FAIR mapping_parser.py.
Currently blocked by source path resolution issue ( returns None).

* Use @ instead of .@ for jmespath compatibility

Changed function annotation from ['@'] to ['@'] (without leading dot)
for proper jmespath current-node semantics.

Test shows multi-mapper creates 3 SelfConsistency instances correctly
and function returns proper convergence criteria data. Final debugging
needed for index error in from_dict subsection removal.

* Fix ruff linting issues

- Fix line length in out_parser.py convergence_density regex
- Remove f-string prefix from max_scf_iterations regex (no placeholders)
- Fix line length in test_fhiaims_parser.py list comprehension
- Remove unused imports from fhiaims.py schema (numpy, Quantity)
- Sort imports in fhiaims.py schema

* Add clarifying comment for SelfConsistency annotation placement

The annotation must be at module level (not inside DFT class) for
multi-mapper detection to work correctly. The mapper needs to scan
all inheriting sections to find multiple annotated subclasses.

* Remove unit from convergence_eigenvalues for consistency

All SCF convergence thresholds (energy, density, eigenvalues) now return
plain floats in their printed units, avoiding mixed Pint Quantity/float
handling.

* Use semantic names to distinguish SCF convergence criteria

Address PR review feedback about semantic ambiguity in convergence criteria
identification. Pre... (continued)

14 of 17 new or added lines in 2 files covered. (82.35%)

10373 of 13519 relevant lines covered (76.73%)

0.77 hits per line