adobe / spectrum-web-components / 30916172232

96%

push

github

[Docs(theme)]: Fix nested sp-theme demo examples ignoring their own attributes (#6570)

* fix(documentation): load theme CSS fragments for nested demo sp-theme examples

Nested `<sp-theme>` elements in markdown demo snippets (e.g. system="express")
never triggered lazy-loading of their CSS fragments; only the global theme
picker did. This left demos silently inheriting the outer page theme instead
of the one declared in the example.

Extract lazyStyleFragment into a shared util and have code-example scan its
live demo markup for sp-theme color/scale/system combinations to preload.

* fix(documentation): gate demo scan behind sp-theme check, add e2e coverage

Address review feedback on #6570:
- Skip parsing every demo's HTML for nested sp-theme tags unless the
  string actually contains one, avoiding createContextualFragment on
  demos that never use it.
- Extract the attribute/system-fallback/branching logic into a pure
  getThemeFragmentRequests helper, decoupled from the DOM.
- Add an e2e spec (run in the existing PR-preview smoke test job)
  asserting the express/light/large demo renders distinctly from the
  spectrum/dark/medium one instead of inheriting the outer theme.

* fix(documentation): rewrite bundle chunk refs to absolute paths

@web/rollup-plugin-html emits chunk/entry script and modulepreload
references relative to each HTML file's own directory (e.g.
`../swc.[hash].js`). That only resolves correctly when the request URL
has a trailing slash, so a page requested without one (as our PR
preview links do, since the Azure $web static host doesn't redirect
to add it) resolves the reference against the wrong directory and
404s, breaking every custom element on the page.

Rewrite those refs to the same domain-absolute, SWC_DIR-aware form
already used for the site's other root-relative asset paths, so
loading no longer depends on the request URL's shape.

6021 of 6465 branches covered (93.13%)

Branch coverage included in aggregate %.

37993 of 39268 relevant lines covered (96.75%)

460.23 hits per line