hyperledger / fabric-x-committer / 30915313864

91%

Build Type

push

github

Committed by web-flow

Commit Message

[query] Fix batcher reference leak when a view is retired mid-query (#741)

#### Type of change

- Bug fix
- Test update

#### Description

- Mark a `viewHolder` as `retired` under its lock when the view is ended
or times out, and
reject `getBatcher()` on a retired view with `ErrInvalidOrStaleView`. As
both the retirement
and the batcher assignment are made under the view's lock, an assignment
either precedes the
  retirement, which then releases it, or is rejected.
- Add unit tests for both orderings of the race: a query that assigns a
batcher only after its
view was retired, either ended or timed out, and a batcher assigned just
before the retirement.

#### Additional details (Optional)

The tests relist the retired view's holder in `viewIDToViewHolder` to
emulate a query that
resolved the holder before the retirement, as such a query cannot be
descheduled deterministically.

#### Related issues

- resolves #740

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

8 of 8 new or added lines in 1 file covered. (100.0%)

13 existing lines in 7 files now uncovered.

10606 of 11639 relevant lines covered (91.12%)

34379.44 hits per line