UI5 / cli / 30894790419

94%

push

github

refactor(builder): Create `sap-ui-version.json` by default (#1453)

JIRA: CPOUI5FOUNDATION-1157

---

**What has been done?**
- Exclusion of task `generateVersionInfo`removed
- now it will be executed by default for every **build** of project type
**`application`** (default, jsdoc, self-contained)
- Tests refactored accordingly
- +new test verifying exclusion/inclusion of `generateVersionInfo`:
[ProjectBuilder.integration.js:2758](https://github.com/UI5/cli/blob/cd38857a4/packages/project/test/lib/build/ProjectBuilder.integration.js#L2758)
- Docs
   - `migrate-v5.md`:  new section explaining new behavior
- `Builder.md`: changed `generateVersionInfo` from disabled to enabled
in Standard Tasks table

**Info**
- for **Server**:
- task `generateVersionInfo` is explicitly NOT executed because
middleware `versionInfo` IS executed (which creates
`sap-ui-version.json` anyways)
- Test verifying exclusion of `generateVersionInfo`:
[BuildServer.integration.js:1030](https://github.com/UI5/cli/blob/<a class=hub.com/UI5/cli/commit/f354410161f654f4622a9ef14c5c3f91f8b33de6">f35441016<a href="https://github.com/UI5/cli/commit/5b522c3cd82a7c56e7c2cbeeb77b9b414aa9ad29">/packages/project/test/lib/build/BuildServer.integration.js#L1030)
- Tests verifying `generateVersionInfo` is added to the `excludedTasks`
array:
[server.js:143](https://github.com/UI5/cli/pull/1453/changes#diff-<a class="double-link" href="https://github.com/UI5/cli/commit/5ee6bf8d5a61e10deb932168617dbec4e094ab2c">5ee6bf8d5</a>529812607a6b46b010917ea8R143-R226)
- (existing) Test verifying `sap-ui-version.json` is generated:
[server/test/lib/server/main.js:204](https://github.com/UI5/cli/blob/f354410161f654f4622a9ef14c5c3f91f8b33de6/packages/server/test/lib/server/main.js#L204)

---------

Co-authored-by: Merlin Beutlberger 
Co-authored-by: Günter Klatt 

7065 of 7758 branches covered (91.07%)

Branch coverage included in aggregate %.

13444 of 13990 relevant lines covered (96.1%)

5473.93 hits per line