goto / guardian / 30891010177

63%

push

github

feat(custom_http): accept the account types the provider config declares (#330)

custom_http passes the account id straight into its templated grant and
revoke requests without interpreting it, so which account types are
meaningful is decided by the target API rather than by the plugin.
Enumerating them in GetAccountTypes meant a provider config could not
declare an account type such as "package", even though the plugin would
have handled it fine.

The plugin now declares AllowsAnyAccountType, and provider account type
validation skips the fixed-list check for providers that implement it.
GetAccountTypes stays as the default applied when a config omits
allowed_account_types, and appeal time validation against the config's
allowed_account_types is untouched, so what a provider accepts is still
restricted, just by its config instead of by the plugin.

Also report which account type was rejected: the check used validator.Var
on a bare string, whose empty namespace produced "Field validation for ''
failed on the 'oneof' tag" with no indication of the offending value.

Co-authored-by: lifosmin.simon <lifosmin.simon@gojek.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

14 of 18 new or added lines in 2 files covered. (77.78%)

14985 of 23656 relevant lines covered (63.35%)

5.38 hits per line