hyperledger / fabric-x-committer / 30889387935
91%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 131
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.144% (-0.1%) from 91.248%
30889387935

push

github

web-flow 
[docs, skills] Fix stale metric names and config-default guidance (#729)

#### Type of change

- Documentation update

#### Description

Docs:

- `docs/performance-tuning.md` — three of the four coordinator rows in
"Key queues to watch" named
metrics that are not exported.
`coordinator_vcservice_output_validated_tx_batch_queue_size` was
renamed by #724; the two `coordinator_sigverifier_*` names never existed
under any release, as
  the subsystem has always been `verifier`.
- `docs/sidecar-block-diagram.md` — the recovery-metrics block named
`sidecar_coordinator_connection_failures_total`, which is
`..._connection_failure_total`, and
gave both connection metrics a `status="connected|disconnected"` label.
They are labelled
  `grpc_target`; connectedness is the gauge's value, not a label.

Skills:

- `development`, `pr-review` — both instructed that every new config
field needs a `Default*` const
and a `v.SetDefault()` in `cmd/config/viper.go`. Neither is how this
repo works: no `Default*`
const exists anywhere, and defaults come from a `default:"..."` struct
tag that
`setDefaultsAndEnv` (`cmd/config/config_preload.go:27`) registers with
viper by walking the
struct type. `cmd/config/viper.go` holds only what a tag cannot express
— the service endpoint
and the `server.*` limits for client-facing services. An agent or
reviewer following the old
text would add a const and a `SetDefault` call the codebase does not
use, and would flag a
  correct change as missing a default.
- `development` — the coordinator `Config` snippet misquoted both scalar
fields as
`validate:"required,gt=0"` and invented two `Default*` consts; corrected
to the real tags. The
`NewLoadBalancedConnection` example still cited
`validator_committer_manager.go:96`, which moved
  to `validator_committer_api.go:39` in #713.
- `development` — record `Provider.NewGaugeFunc`, added in #724, as the
way to report a value that
is already available on demand (a channel length, a queue depth) instead
... (continued)

10601 of 11631 relevant lines covered (91.14%)

34082.24 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
85.63
 -1.13% service/vc/database.go
4
95.0
 -0.83% mock/coordinator.go
4
86.24
 -3.67% loadgen/adapters/broadcast.go
3
82.61
 -13.04% service/query/lock_free.go
2
95.58
 -1.77% mock/vcservice.go
1
78.29
 -0.19% service/sidecar/sidecar.go
Jobs
ID Job ID Ran Files Coverage
1 unit-test - 30889387935.1 95
84.6
 GitHub Action Run
2 db-test - 30889387935.2 131
78.89
 GitHub Action Run
3 core-db-test - 30889387935.3 100
46.86
 GitHub Action Run
Source Files on build 30889387935