dangernoodle-io / breadboard / 30866341420

97%

push

github

fix: delegate bb_display_st77xx_clear to bb_display_clear_spi to fix DMA use-after-free (B1-572) (#1215)

bb_display_st77xx_clear() malloc'd a DMA scanline buffer, issued LCD_HEIGHT
back-to-back async esp_lcd_panel_draw_bitmap() calls, then freed the buffer
immediately after the loop with zero wait on transfer completion — freeing
the DMA source while transfers were still in flight on ST7789/ST7735 boards
(the live .clear vtable entry for both). Delegate to bb_display_clear_spi()
instead, mirroring the already-HW-validated ili9341 path; it uses a
counting semaphore to block until every issued draw_bitmap has completed
before returning.

No ST hardware on hand for this change — on-device validation (ST7789 and/or
ST7735) is flagged as a post-merge gate.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

8294 of 8858 branches covered (93.63%)

Branch coverage included in aggregate %.

14024 of 14179 relevant lines covered (98.91%)

2610.57 hits per line