GEWIS / sudosos-backend / 30835673839

92%

push

github

fix: capture card-present terminal payments immediately (#1007)

The terminal branch of createStripePaymentIntent asked for
capture_method: 'automatic' at the top level, then overrode it with
payment_method_options.card_present.capture_method = 'manual_preferred'.
Card-present supports manual capture, so the override won and every
intent landed in requires_capture. Nothing in src/ ever calls
paymentIntents.capture, so the authorization sat on the card for 48
hours and then expired.

The webhook path broke too. Manual capture emits
payment_intent.amount_capturable_updated rather than
payment_intent.succeeded, and that event is neither subscribed to nor
handled, so the TerminalPayment stayed in PROCESSING and the frontend
polled forever. The only way out was a cancel, which released the hold
and looked to the customer like an instant refund.

Dropping the override lets card-present inherit the top-level automatic
capture. The tap captures right away and fires payment_intent.succeeded,
which StripeWebhookService already routes to
TerminalPaymentService.handleTerminalPaymentSuccess.

Fixes GEWIS/sudosos-backend#1005

4424 of 5034 branches covered (87.88%)

Branch coverage included in aggregate %.

22539 of 24189 relevant lines covered (93.18%)

826.68 hits per line