FlexMeasures / flexmeasures / 30827085192

83%

main: 84%

Build Type

Pull #2382

github

Committed by Flix6x

Commit Message

Address review: install the trigger from the metadata, and fix stale docstrings

The trigger DDL was attached to timed_belief's own after_create,
but the function it installs refers to sensor_data_source,
and nothing orders that table's creation relative to timed_belief's.

The failure this could cause is narrower than it looks:
plpgsql resolves table references lazily,
so creating the function and trigger succeeds even when the referenced table does not
exist yet, which is why the tests passed.
Verified that directly against PostgreSQL rather than assuming it.
But relying on late binding is a fragile reason for it to work --
a function written in plain SQL would be bound eagerly and fail --
so move the listener to the metadata, where it runs once every table exists.

Doing so needed the DDL to become a small Python listener rather than a DDL object,
because guarding it in SQL would mean nesting dollar-quoted bodies inside a DO block.
The listener skips quietly unless both tables are present,
so a partial create_all does not break.

Also fix two docstrings that still described the old implementation.
Sensor.data_sources claimed to scale by not fetching every belief row,
which stopped being how it works;
and search_data_sources had no note that where its answer comes from now depends on
whether time filters are given, which is the one thing a caller needs to know.

flexmeasures/data: 256 passed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: F.N. Claessen <felix@seita.nl>

Pull Request Pull Request #2382: Summarise which sources recorded for which sensors

Coverage Stats

19 of 22 new or added lines in 2 files covered. (86.36%)

35 existing lines in 2 files now uncovered.

16611 of 19902 relevant lines covered (83.46%)

0.83 hits per line