chrisns / repomanager / 30817296880

86%

master: 86%

Pull #1621

github

Restore the full pull_request rule so ruleset creation works

Creating the default ruleset has been failing on every new repo with
"Invalid property /rules/3: data matches no possible input" — currently
chrisns/govbuy, chrisns/obsidian-highlight-comment and chrisns/uk-tenders-mcp,
all showing the failure marker on their consent issues.

0f21a79 dropped dismiss_stale_reviews_on_push, require_last_push_approval and
allowed_merge_methods on the grounds that they are moot at 0 required reviews.
They are moot semantically, but GitHub's create-ruleset endpoint rejects a
partial `pull_request` rule outright.

It stayed invisible because rulesetEquals compares with subset semantics: every
ruleset created before that commit still carries the full parameter set, so the
shortened rule kept matching them and no update was ever proposed. Only repos
needing the ruleset created from scratch hit it, and they hit it forever.

`merge` stays in allowed_merge_methods to match the rulesets already deployed,
so this doesn't propose a ruleset update on every repo in the fleet. The
repo-level allow_merge_commit: false is what actually blocks merge commits.

Claude-Session: https://claude.ai/code/session_013MKCzima2XjGrHTYkY7F2y

435 of 553 branches covered (78.66%)

Branch coverage included in aggregate %.

699 of 766 relevant lines covered (91.25%)

21.77 hits per line