newrelic / infrastructure-agent / 30816131381

53%

Build Type

push

github

Committed by web-flow

Commit Message

feat(oci): add OCI tag support to match AWS tags (Phase 1 + Phase 2) (#2295)

* feat(oci): add OCI tag support to match AWS tags (Phase 1 + Phase 2)

Populates OCI cloud attributes as inventory, per the CDD "OCI Tag Support
to Match AWS Tags in New Relic Infrastructure" (Confluence 5846532426):

Phase 1 (IMDS + static values, no new dependencies):
- cloud.resource_id, oci.compute.instanceId, oci.compute.faultDomain,
  oci.network.privateIp, oci.network.privateDnsName, host.arch,
  cloud.provider, cloud.platform
- Freeform tags collected from IMDS, filtered via new oci_tags_exclude
  config option, flattened into label.* inventory attributes

Phase 2 (OCI SDK + instance principal auth, github.com/oracle/oci-go-sdk/v65):
- oci.network.vcnId, oci.network.subnetId, oci.compute.lifecycleState,
  oci.compute.virtualizationType, oci.compute.dedicatedVmHostId
- Best-effort only: failures (e.g. missing IAM policy) are logged and
  leave the attribute empty, never block agent startup

Extends the cloud.Harvester interface with the new getters (stubbed as
ErrMethodNotImplemented on AWS/Azure/GCP/Alibaba), and adds MarshalJSON
on the platform-specific HostInfo{Linux,Darwin,Windows} structs (not on
any embedded type, to avoid Go's method-promotion overriding marshaling
of the parent struct) to flatten freeform tags into label.* attributes.

Verified end-to-end against a real OCI compute instance, including both
the IAM-policy-missing (graceful degradation) and IAM-policy-present
(full Phase 2 population) paths.

vendor/ is intentionally not synced in this commit - go.mod/go.sum were
updated by `go build -mod=mod` with real checksums; vendor/modules.txt
needs `go mod vendor` from an environment with network+tooling access
before merge.

* fix: resolve golangci-lint findings from PR feedback

Addresses the linter-linux/macos/windows and licenses-check CI failures on
PR #2295:

- Regenerate THIRD_PARTY_NOTICES.md for the new oci-go-sdk/v65 dependency
- wrapcheck: wra... (continued)

Coverage Stats

190 of 539 new or added lines in 12 files covered. (35.25%)

2 existing lines in 1 file now uncovered.

14807 of 27747 relevant lines covered (53.36%)

18.07 hits per line