valkyrjaio / project-template-ts / 30793772942
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30793772942

push

github

web-flow 
[Eslint] ci: Add the check script that CI needs to call (#102)

# Description

This repository has no `eslint-check` script. The other TypeScript
repositories have one, and every
repository has the matching pair for prettier: `prettier` writes, and
`prettier-check` never does.

The gap matters because of what CI runs. `_ts-ci-tool.yml` resolves the
eslint tool to
`npm run eslint`, and it resolves the prettier tool to `npm run
prettier-check`. ESLint is therefore
the one tool whose gate can write, and a repository whose `eslint`
script fixes runs the fixer in
CI. A wrong copyright header is then rewritten in the throwaway
checkout, the step exits 0, and the
gate reports success over a repository that is wrong.

This repository is not in that state today, because its `eslint` script
already runs the check. It
is missing the name that CI needs to call instead. This pull request
adds the pair, so the scripts
match the other repositories and match prettier:

- `eslint` — fixes
- `eslint-check` — never writes

Warning: this pull request does not change what CI runs. A separate pull
request in the `.github`
repository points `_ts-ci-tool.yml` at `eslint-check`, and it must merge
**after** this one. Merged
first, it would call a script that does not exist here.

## What this pull request verified

- The full gate passes: `typescript`, `eslint-check`, `prettier-check`,
and `vitest-coverage`.
- `npm run eslint`, the new fixing variant, runs and rewrites no file.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`package.json`** — `eslint` runs the fixing variant, and the new
`eslint-check` runs the
che... (continued)

2 of 2 relevant lines covered (100.0%)

1.0 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30793772942.1 1
100.0
 GitHub Action Run
Source Files on build 30793772942