30786723857
91%

Ran 03 Aug 2026 05:20AM UTC

Jobs 3

Files 131

Run time 1min

Badge

Embed ▾

Committed 03 Aug 2026 05:16AM UTC coverage: 91.142% (-0.1%) from 91.255%

Build # 30786723857

Build Type

push

github

Committed by

web-flow

Commit Message

[sidecar, skills] Assert notifier metrics as eventually consistent (#727)

#### Type of change

- Test update
- Documentation update

#### Description

- `TestNotifierDirect`: the metric assertions that follow a response
read now use
`test.EventuallyIntMetric`. Only the initial-state block keeps
`test.RequireIntMetricValue`,
  where nothing is in flight yet.
- The timeout step is asserted as a single `require.EventuallyWithT`
condition. That step ends
with both gauges back at the values they already held, so asserting them
on their own would not
prove the timeouts were recorded; the timeout counter is the only value
the step changes, and
requiring all three at the same instant is what keeps the gauges
meaningful.
- `tests` skill: state that a metric is only eventually consistent with
the worker's observable
effect, and that an eventual assertion is vacuous when the expected
value is the one the metric
already holds. Its "Pattern 2" example was the racy form of these very
assertions.

#### Related issues

- resolves #690

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

10526 of 11549 relevant lines covered (91.14%)

34822.77 hits per line

Coverage Regressions

Lines	Coverage	∆	File
11	79.07	-1.94%	service/sidecar/sidecar.go
3	85.12	-1.04%	service/sidecar/relay.go
3	64.71	-17.65%	utils/serve/server.go
2	91.58	-1.05%	service/coordinator/validator_committer_manager.go
1	82.0	-2.0%	loadgen/adapters/coordinator.go
1	96.63	-1.12%	mock/sigverifier.go
1	88.99	-0.92%	loadgen/adapters/broadcast.go
1	94.95	-1.01%	loadgen/adapters/common.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	db-test - 30786723857.1	03 Aug 2026 05:22AM UTC	131	79.12	GitHub Action Run
2	unit-test - 30786723857.2	03 Aug 2026 05:22AM UTC	95	84.51	GitHub Action Run
3	core-db-test - 30786723857.3	03 Aug 2026 05:20AM UTC	100	46.55	GitHub Action Run

hyperledger / fabric-x-committer / 30786723857
91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 30786723857

hyperledger / fabric-x-committer / 30786723857 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 30786723857

hyperledger / fabric-x-committer / 30786723857
91%

README BADGES
x