hyperledger / fabric-x-committer / 30786611240

91%

Build Type

push

github

Committed by web-flow

Commit Message

[coordinator] Align VC and verifier manager stream behavior (#725)

#### Type of change

- Bug fix
- Test update

#### Description

- Bind both managers to one receive-error classification,
`classifyStreamRecvError`. The VC
manager previously retried an `InvalidArgument` under the sustain policy
forever; the verifier
  manager already treated it as non-retryable.
- Skip empty batches in the VC send loop instead of marshalling and
sending an empty `VcBatch`.
- Do not forward an empty batch from the verifier's receive loop to the
VC manager, which is
where those empty batches came from. The VC manager already guards its
own output this way.
- Record at the VC's receive goroutine what breaks if the two output
writes are bound to the
stream context rather than the manager's: the re-queue becomes reachable
on every stream
  failure, the statuses of a re-queued batch are delivered twice, and
`Service.numTxsInProgress` is decremented twice for one transaction. The
existing NOTE stated
the requirement but not its consequence, which is what makes it easy to
undo.

#### Additional details (Optional)


`TestValidatorCommitterManagerX/an_empty_batch_is_not_sent_to_the_vcservice`
sends a real batch
first, because the first batch of a stream goes through
`splitAndSendToVC`, which already sends
nothing for an empty batch — the empty send is only reachable once that
path is behind us. With
the guard removed the test observes three batches on the wire instead of
two.

No behavior changed for the failed-forward re-queue itself. The status
write is already attempted
first and returns early on failure, so the nodes are never forwarded for
a batch whose statuses
were dropped; the reverse ordering cannot be fixed by ordering and is
instead held unreachable by
the context wiring, which is what the NOTE now explains.

This touches the same receive and send loops as #724, so whichever
merges second needs a trivial
rebase.

#### Related issues

- resolves #721

Signed-off-by: ... (continued)

Coverage Stats

17 of 17 new or added lines in 2 files covered. (100.0%)

17 existing lines in 6 files now uncovered.

10544 of 11547 relevant lines covered (91.31%)

33581.35 hits per line