FAIRmat-NFDI / pynxtools-raman / 30767575530

96%

push

github

Map ROD publication and database citations into NXcite entries (#59)

* Add ROD publication and database citations to Raman entries

Maps the publication metadata already parsed from .rod files (author,
title, journal, DOI, ...) plus the ROD record itself into two citeID
NXcite instances per entry, instead of letting them fall through to
unused_rod_keys. Targets the citeID(NXcite) group being added to
NXoptical_spectroscopy upstream; until that lands, the fields are
written but flagged undocumented since NXraman doesn't declare the
group yet.

* Remove stale ignore-section entry from raman reader test

The "ATTRS (//@creator_version)" DEBUG-value ignore no longer matches
anything the reproducibility check emits.

* Fix ruff PLR0917 (too many positional arguments) in test_reader.py

pytest already calls test_nexus_conversion with keyword arguments
matched by parametrize/fixture name, so making the parameters
keyword-only is a no-op for pytest and satisfies the lint rule.

* Fall back to _chemical_name_systematic for SAMPLE/name in ROD reader

_chemical_name_mineral is blank for synthetic/non-mineral ROD records;
_chemical_name_systematic is the next-best name available in those
cases. Same fallback-list notation already used for chemical_formula
and title in this config file.

---------

Co-authored-by: lukaspie <lukaspie@github.com>

128 of 128 new or added lines in 4 files covered. (100.0%)

418 of 457 relevant lines covered (91.47%)

0.91 hits per line