PHPCSStandards / PHP_CodeSniffer / 30766473066

79%

master: 79%

push

github

Tokenizer/PHP: fix "Undefined array key" warning during live coding (#1461)

As things were, during live coding it would be possible for the code handling typed constants - as introduced in #321 - to throw an "Undefined array key" warning.

This would happen in live coding situations, when the constant name is the last non-empty token in the file. In that case, the `for` loop ends via its `$i < $numTokens` condition with `$i` equal to `$numTokens`. The following `$tokens[$i] === '='` check then reads an index that does not exist, which triggers the "Undefined array key" error.

Fixed now.

Includes a test which would fail on the warning being thrown without the fix.

Co-authored-by: Sai Asish Y <say.apm35@gmail.com>

1 of 1 new or added line in 1 file covered. (100.0%)

19891 of 25184 relevant lines covered (78.98%)

99.19 hits per line