archetech / archon / 30765152346

94%

push

github

test(keymaster): cover the DIDComm protocol builders' optional branches (#826)

didcomm-protocols.ts sat at 96.2% lines but only 38.9% branches — the
signature of code that runs in tests but only ever with one shape of
input. Every builder was called with its optional arguments omitted, so
each `thid ? { thid } : {}`, optional `comment`, and default parameter
had one side that never executed.

Those branches are not incidental: the threading identifier is what ties
a DIDComm response back to its request. requestCredential(thid),
mediateGrant(routingDid, thid), keylistUpdateResponse(updated, thid) and
keylist(dids, thid) had never emitted a thid in any test.

20 tests added (10 -> 30), taking the file to 100% branches and 100%
lines. Cases chosen for where this shape of code usually breaks:

- requestCredential(undefined, comment) — a comment with no thid must not
  invent one, which is easy to get backwards with spread-conditionals.
- encodeOutOfBandInvitation against a base that already carries a query
  string, exercising the ? vs & separator, plus a round trip through a
  payload containing ? and ~ so the hand-rolled base64url substitution of
  +/ to -_ is actually exercised.
- attachedJson against malformed messages ({}, empty attachments, missing
  data, out-of-range index, null) — it parses data that arrived over the
  wire, so it must return undefined rather than throw.
- outOfBandInvitation with an explicit accept, confirming it overrides
  the default rather than appending to it.

Repo branch coverage 83.15% -> 83.90%.

Note for anyone reading the Coveralls number: its headline blends lines
and branches, (covered_lines + covered_branches) / (relevant_lines +
relevant_branches), so it reads well below the lines-only figure. Lines
are near done at ~95.9%; branches are the remaining dimension.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

3507 of 4060 branches covered (86.38%)

Branch coverage included in aggregate %.

8159 of 8511 relevant lines covered (95.86%)

669.07 hits per line