dangernoodle-io / breadboard / 30764553383

97%

push

github

feat: add kconfig-inert-symbol lint rule (#1203)

Flags a Kconfig config NAME never actually consulted anywhere: no
CONFIG_NAME reference in any C/H source, CMakeLists/*.cmake, or bbtool's
own Python tooling, and no other Kconfig entry's depends on/select/
default names it bare. A bare cross-reference from another entry's
depends on/select/default counts as real usage (it changes Kconfig's
own resolved graph); a mention only in help prose or a code comment does
not. A choice member consulted only via a C #if/#elif.../#else chain's
terminal #else arm (naming its other, mutually-exclusive choice siblings
and never itself) also counts as real usage -- without this, a choice
with no default and only some members named explicitly would falsely
flag its unnamed member(s) as inert (real in-tree near-miss:
BB_WIFI_PS_MIN_MODEM, rescued today only because its choice happens to
carry a default naming it).

An initial audit found 12 genuinely inert symbols in-tree, not the 5 an
earlier pass claimed; adding the #else-arm detection above rescues one
more (BB_OTA_STRATEGY_NONE), leaving 11. Shipped as severity=warn (not
error) with an empty allow list by default, since pre-populating the
existing 11 would permanently normalize them as sanctioned exceptions
instead of surfacing them on every run -- a deliberate warn-forever
choice over a shrink-only ratchet (see scripts/bbtool/README.md).

B1-1377

8220 of 8784 branches covered (93.58%)

Branch coverage included in aggregate %.

13914 of 14069 relevant lines covered (98.9%)

2682.99 hits per line