lsm / HyperNeo / 30762976809

83%

Build Type

push

github

Committed by web-flow

Commit Message

feat: generic artifact shapes — shape-based save_artifact + backend migration (#796 PR A) (#2313)

* feat(shared): add closed generic artifact shape vocabulary

Introduce a domain-agnostic, closed SHAPE vocabulary (link, commit_set,
check, metric, decision, note) with a freeform KIND semantic hint. A PR,
an issue, and a preview page are all 'link' with different kinds; infra
never names domain kinds.

The new artifact-shapes module is pure (no zod/I/O) so daemon and web can
share it, and provides:
- ARTIFACT_SHAPES / ArtifactShape closed set + per-shape data contracts
- isArtifactShape / validateArtifactShape (per-shape required-field checks)
- deriveArtifactKey (shape-aware identity: note→single upsert, link→one
  per kind, check/metric→name, decision→key|kind|'current')
- resolveLegacyShape (data-aware legacy type→shape router; result is
  overloaded so it picks link vs decision by content)
- normalizeLinkData (copy pr_url/review_url onto data.url for link rows)

Task #796 (PR A — backend foundation).

* feat(space): validate save_artifact against generic shapes; migrate backend

Replace the freeform save_artifact type system with the closed shape
vocabulary. save_artifact now takes { shape, kind?, key?, summary?, data? },
validates the payload against the per-shape contract, rejects unknown shapes,
and derives a shape-aware identity key so a 'note' is a single rolling-status
upsert (no per-round growth) and a 'link' is one-per-kind.

A data-aware legacy shim keeps in-flight agents working: { type } is mapped
to a shape (progress→note, result→link|decision by content, review→decision,
pr→link kind:pr) and bypasses strict validation since it predates the
contracts; unknown legacy types are still rejected.

Migrate every backend reader/writer off legacy types:
- review auto-save (review-posted-gate) → decision kind:review, keyed round-N
- list_peers rolling status → note (data.text ?? summary)
- resolvePrUrlForRun (x3) → link kind:pr, data.url, with l... (continued)

Coverage Stats

12283 of 17501 branches covered (70.18%)

Branch coverage included in aggregate %.

426 of 523 new or added lines in 10 files covered. (81.45%)

1 existing line in 1 file now uncovered.

104464 of 122591 relevant lines covered (85.21%)

297.43 hits per line