kubevirt / containerized-data-importer / #6150

50%

Build Type

push

travis-ci

Committed by web-flow

Commit Message

fix: advise csi-clone strategy for Portworx pure_block/pure_fa_file storage classes (#4218)

* fix: advise csi-clone strategy for Portworx pure_block/pure_fa_file storage classes

Motivation:
For a pxd.portworx.com StorageClass with parameter backend=pure_block
(or backend=pure_fa_file), the StorageProfile controller advises the
"snapshot" clone strategy instead of "csi-clone" when populating a
DataVolume from a golden PVC. This means CDI takes the less efficient
snapshot-and-restore path instead of using CSI clone, even though
Portworx supports CSI clone for these backends just like it does for
the base pxd.portworx.com and pxd.portworx.com/nfs provisioner keys.
User-visible behavior for the clone itself is otherwise unaffected
(the clone still succeeds), the only change is which cloning mechanism
is chosen.

Approach:
storageClassToProvisionerKeyMapper["pxd.portworx.com"] derives the
provisioner keys "pxd.portworx.com/pure_block" and
"pxd.portworx.com/pure_fa_file" from the StorageClass's "backend"
parameter, and CapabilitiesByProvisionerKey already has entries for
both. However CloneStrategyByProvisionerKey was missing entries for
these two derived keys, so GetAdvisedCloneStrategy() found no known
strategy and the controller fell back to its generic default
(snapshot if a VolumeSnapshotClass exists, otherwise host-assisted).
Add the two missing entries, mirroring the existing sibling entries
"pxd.portworx.com" and "pxd.portworx.com/nfs" which are both already
CloneStrategyCsiClone.

Validation:
Added a table test reproducing the bug for both backend values, and
confirmed (by temporarily reverting the map change) that it fails
before the fix with "Expected snapshot to equal csi-clone" and passes
after.

  GOWORK=off go test ./pkg/controller/ -run TestController

Ran 367 of 367 Specs in ~2.2 seconds
SUCCESS! -- 367 Passed | 0 Failed | 0 Pending | 0 Skipped

```release-note
Fixed StorageProfile controller advising the wrong clone strategy for Portworx... (continued)

Coverage Stats

0 of 2 new or added lines in 1 file covered. (0.0%)

7 existing lines in 1 file now uncovered.

15133 of 30406 relevant lines covered (49.77%)

0.56 hits per line