zentralopensource / zentral / 30754867327

90%

push

github

Attribute the APNs notifications an operator asks for (#1565)

Poking a device or a user changes nothing, so it has no audit event, and the
mdm_device_notification event it produces was built with the serial number alone.
The one record of an operator poking a device did not say who did it.

The notification event now carries the request context when a request is passed
down. The engine callers, the artifact reconciliation and the Apps and Books
preprocessor, and the send_device_notification management command pass nothing, so
an operator poke can be told apart from one Zentral decided on by itself.

The request is threaded from every operator entry point, not just the two poke
views: blocking a device from the web interface or the API, and changing a device's
blueprint, all notify the device, and an event that names the request that caused
the push is strictly more useful than one that does not.

The two poke views had no tests at all. They now have the usual redirect and
permission checks, and a test each asserting the emitted notification event carries
the operator username and the resolved view name, driven through the real APNs code
path with only the HTTP layer mocked. Those two need a full size push certificate
key: the reduced size the other fixtures use cannot build an SSL context.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

13 of 13 new or added lines in 4 files covered. (100.0%)

49965 of 55773 relevant lines covered (89.59%)

0.9 hits per line