Kikobeats / reachable-url / 30746591216

100%

push

github

fix!: abort the download when a server ignores Range (#77)

* fix!: abort the download when a server ignores Range

The request asks for one byte, but a server may ignore `Range` and send
the whole entity, which `responseType: 'buffer'` then buffers in full.
Probing an 8 MB file transferred all 8 MB to read a status line.

Cancel once the response starts: status and headers already answer
whether the URL is reachable. Measured on an 8 MB body, 0.56 MB crosses
the wire instead of 8 MB, the rest being what is already in flight.

Not when `cache` is passed: cacheable-request writes its entry on `end`,
which a cancelled response never emits, so caching keeps the full body.
Not on 5xx either, since got retries those and a CancelError is not
retryable, and not when the server honored the range and sent one byte.

An aborted response reports `body` as `undefined` rather than the body of
the previous retry attempt, and keeps `timings.phases.total`, which the
timer only fills on `end`.

BREAKING CHANGE: `body` is `undefined` on responses whose download was
aborted. Pass `cache` to keep the previous behaviour.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018JDsM3McLV5LtR3rFd97Sb

* feat: reject the cache option without the patched cacheable-request

The cacheable-request got resolves never settles when the origin keeps
the connection alive, and got's own timeout does not fire, so the request
hangs with no stack and nothing to grep for. An override redirects it to
@kikobeats/cacheable-request, but overrides do not reach consumers of
this package, and the pnpm one silently stopped applying once pnpm moved
that setting out of package.json.

Throw instead, naming the override that fixes it. Only when `cache` is
passed, since that is the only path that hangs.

Detection reads the module shape rather than its resolved path, because a
path can be rewritten by bundlers and aliases: upstream is a clas... (continued)

37 of 37 branches covered (100.0%)

Branch coverage included in aggregate %.

74 of 74 new or added lines in 1 file covered. (100.0%)

143 of 143 relevant lines covered (100.0%)

353.64 hits per line