zhaozg / lua-openssl / 30744753549

94%

master: 93%

Build Type

push

travis-ci

Committed by zhaozg

Commit Message

fix(cms): accept nil certs in cms.sign and guard empty-CMS methods

Two crash/UX issues reported against the cms module:

#411: cms.sign(signer, pkey, data) raised
  'bad argument #4 to sign (must be a table as array or nil)' even though
  nil is documented as acceptable. The TAB2SK macro (sk.h) that converts
  Lua tables to STACK_OF(X509) forced a table via luaL_argcheck while its
  message promised nil was fine. The check now accepts none/nil and the
  macro returns an empty stack, so every module built on openssl_sk_*_fromtable
  (cms, pkcs7, pkcs12, ocsp, ots, x509) accepts nil for optional cert lists.

#413: cms.new():detached(true)/detached()/content()/final("hi") segfaulted.
  CMS_ContentInfo_new() creates an object with no contentType set, and the
  OpenSSL accessors CMS_get0_content/CMS_is_detached/CMS_set_detached/CMS_final
  do not handle that case. Added cms_has_content_type() guard:
  * detached() getter returns false on empty CMS
  * detached(true)/final() return nil, err, code on empty CMS
  * content() returns nil on empty CMS
  * detached setter also now returns openssl_pushresult() instead of
    returning an uninitialized stack value

Tests cover both regressions (test/6.cms.lua:testSignNoCerts, testEmptyObject).
Verified against OpenSSL 1.0.2 and 3.6.

Fixes #411, #413

Coverage Stats

16 of 16 new or added lines in 1 file covered. (100.0%)

17 existing lines in 1 file now uncovered.

10584 of 11270 relevant lines covered (93.91%)

1999.54 hits per line