valkyrjaio / valkyrja-starter-app-php / 30742846658
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 33
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30742846658

push

github

web-flow 
[Workflow] ci: Add the Markdown formatting check (#222)

# Description

The `bin/sindri` entry point carried the wrong package identifier in its
copyright header, and no tool reported it. PR #221 corrects the
identifier. This
pull request closes the gap that let the identifier drift.

**This pull request stacks on PR #221.** Merge #221 first. Until then
this pull
request shows both commits, because the check that this pull request
adds fails
on a wrong identifier — which is the point of it.

The gap has two parts, and both are closed here:

1. **The finder did not match the file.** PHP CS Fixer matches `*.php`,
and
`bin/sindri` has no extension. The finder now also matches the name
`sindri`.
The file is a PHP entry point whose first comment is the license header,
so
   the header rule is safe to point at it.
2. **The filter named a file that no longer exists.** The `source-paths`
filter
in `ci.yml` listed `bin/valkyrja`. The entry point was renamed to
`bin/sindri`
and the filter kept the old name, so an edit to the entry point started
no
tool. A path filter fails silently when its path is wrong: it matches
nothing
and the job is skipped, which reads the same as a clean run. The filter
now
   names `bin/sindri`.

Warning: the `header_comment` fixer replaces the first comment block in
a file.
`bin/sindri` was read first to confirm that its first comment is the
license
header, and the full fixer run was then read as a diff, not trusted as a
green
exit code.

Sibling pull requests for the other affected repositories:

- `valkyrja-starter-app-java` —
https://github.com/valkyrjaio/valkyrja-starter-app-java/pull/101
- `valkyrja-starter-app-php` —
https://github.com/valkyrjaio/valkyrja-starter-app-php/pull/225

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which r... (continued)

517 of 517 relevant lines covered (100.0%)

2.12 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30742846658.1 33
100.0
 GitHub Action Run
Source Files on build 30742846658