Kikobeats / reachable-url / 30740427207

100%

push

github

fix: restore the cacheable-request override and make the suite deterministic (#75)

* test: replace dead third-party hosts with local servers

ftp.nluug.nl now 404s the Blender .mov and httpbin.org returns 503, so
`cache › static asset`, `don't download the whole body` and the four
httpbin-backed tests fail on master. Because ava runs --serial, the
hanging cache test also stopped every test after it from running.

Move them onto local servers via test/_helpers.js. Coverage goes from
85.71% to 100%: the 206 -> 200 content-range rewrite was never exercised
because the tests covering it were the ones failing.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018JDsM3McLV5LtR3rFd97Sb

* test: cache a plain 200 asset instead of a 206

`cache › static asset` was storing a partial response: got sends
`Range: bytes=0-0`, so the old ftp.nluug.nl .mov and the range server
replacing it both answered 206. Replaying a cached 206 stalls on Linux,
which is why the test hung on ubuntu-latest both before and after the
host swap while passing on macOS.

The test's assertions are about isFromCache and cache size, so serve a
plain cacheable 200. Range handling stays covered by index.js
`don't download the whole body`.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018JDsM3McLV5LtR3rFd97Sb

* test: trace static asset cache test

* test: probe matrix for the cache hang

* test: keep the static asset cache test on a remote origin

Reverts the local server and the debugging scaffolding. A local server
cannot work here: `{ cache }` against a keep-alive HTTP/1.1 origin never
resolves on Linux, so the first request hangs and --serial takes the rest
of the suite with it.

Isolated with a probe matrix on CI, varying one factor at a time:

  1 no cache, plain 200        -> 200
  2 cache, plain 200           -> TIMEOUT
  3 cache, no cache-control    -... (continued)

13 of 13 branches covered (100.0%)

Branch coverage included in aggregate %.

80 of 80 relevant lines covered (100.0%)

376.84 hits per line