source-academy / frontend / 30735213100

45%

push

github

Module tabs outside Playground + Ground Control default language from language directory (#4226)

* Pass workspaceLocation into getPreparedConductorSaga so module tabs render outside Playground

sideContentManager is a singleton keyed by one internal workspaceLocation,
defaulting to 'playground' and only ever corrected via setWorkspaceLocation,
which conductorEvaluatorCache.ts only calls when options.workspaceLocation is
passed. The actual Run call site never passed it, even though the variable
was right there in scope, so any module's dynamically-registered side-content
tab (rune's display, sound's visualizer, etc.) silently failed to render for
every workspace except Playground - not a #4057 regression, this call site
predates it.

* Source Ground Control's default language menu from the language directory

The menu was hard-wired to the legacy Source-only sourceLanguages array,
so it never listed Python/Scheme even though Conductor already made those
selectable everywhere else. Once Conductor is enabled, its items and current
selection now come from state.languageDirectory.languages instead, reusing
sourceChapter as a 1-based index into that array (same convention as
chapterLanguage.ts's deriveLanguageFromChapter) so no backend schema change
is needed. Legacy Source behaviour is unchanged when Conductor is disabled.

Also narrows changeSublanguage's payload type to just the chapter/variant
fields it actually persists, since those are all BackendSaga reads from it.

3032 of 7765 branches covered (39.05%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

6989 of 14505 relevant lines covered (48.18%)

30.31 hits per line