boardgameio / boardgame.io / 30730117027

100%

master: 100%

push

github

build(integration): stop test:integration modifying tracked files (#1315)

* build(integration): keep the integration install out of the root workspace

`pnpm add` of the local tarball walks up to the repo root, registers
integration/ as a workspace importer and writes the tarball into the root
pnpm-lock.yaml — a change that must never be committed but sits in the
working tree after every run. `pnpm install` alone does not do this; only
the tarball add does. --ignore-workspace pins both commands to the scaffold,
which is what they meant all along: it has its own gitignored lockfile.

* build(integration): restore the scaffold manifest after installing the tarball

`pnpm add` always saves to the manifest and pnpm 10 has no --no-save, so
every run left `boardgame.io: file:boardgame.io-<version>.tgz` in
integration/package.json — a tracked file, and a line that pins a version
that only exists on the machine that built it.

Snapshotting and writing the manifest back straight after the install means
a failing check further down cannot leave it dirty either. The checks
resolve the package through node_modules, which is already populated by
then.

---------

Co-authored-by: Rupesh Pandey <pandeyrupesh00@gmail.com>

2038 of 2038 branches covered (100.0%)

Branch coverage included in aggregate %.

2918 of 2918 relevant lines covered (100.0%)

26370.96 hits per line