valkyrjaio / sindri-ts / 30728412464

100%

push

github

[CopyrightHeader] ci: Cover the .github/ci files with the header and formatter (#111)

# Description

The PHP repositories had every `.php` file under `.github` sitting
outside the license
header rule, and that was fixed in the recent header batch. The same
question was then
asked of TypeScript, and the answer is the same: nothing reached the
`.ts` and `.js`
files under `.github/ci`.

Every TypeScript and JavaScript file in this repository was enumerated
and compared
against the ESLint scope and the Prettier scope. `.github/ci` was
uncovered: three files that neither tool touched, and none of them
carried the license header.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`.github/ci/eslint/eslint.config.js`**,
**`.github/ci/prettier/prettier.config.js`**, and
**`.github/ci/vitest/vitest.config.ts`** — each gained the license
header naming
`Sindri`, and each was reformatted by `npm run prettier` on first
coverage.

- **`.github/ci/prettier/package.json`** — `check` and `fix` now include
`.github/ci/**/*.ts` and `.github/ci/**/*.js`, so these files stay
formatted.
- **`.prettierignore`** — `coverage` is added. See the warning below.

## Warning: the new glob reaches the coverage report

`.github/ci/**/*.js` matches `.github/ci/vitest/coverage/lcov-report/`,
which holds
three vendored JavaScript files that Istanbul writes:
`block-navigation.js`,
`prettify.js`, and `sorter.js`. They are third-party generated output
and must never be
reformatted.

Without the `.prettierignore` entry, `prettier-check` fails on them as
soon as a coverage
report exists. That is easy to miss locally, because a clea... (continued)

990 of 990 branches covered (100.0%)

Branch coverage included in aggregate %.

1601 of 1601 relevant lines covered (100.0%)

24.09 hits per line