dangernoodle-io / breadboard / 30726902662

97%

push

github

fix: surface discarded composition-root init errors instead of silently dropping them (#1187)

entry_espidf.c discarded bb_app_init_early()/bb_app_init_rest()'s return
values entirely, so a failed component init (confirmed on hardware: a
bb_data table exhaustion causing bb_ota_check_config_bind() to fail) could
drop a component's HTTP routes and periodic worker with zero trace in the
boot log. Capture both returns and log loudly (bb_log_e) on failure, then
continue booting -- every init call in the generated composition is
already non-fatal by construction (first-error semantics, no early exit),
so a top-level abort here would contradict that established contract and
turn one non-critical component's failure into a field-bricking boot loop.

Also fixes the specific silent-early-return chain in
bb_ota_check_register_init(): every early return in that function now
logs before propagating, matching the bb_sensor_http.c sibling idiom.

Audited generated/bb_app_init.c and examples/floor/main/floor_app.c for
the same shape: floor logs on every init call site except two --
bb_log_stream_init() and bb_log_config_init() at floor_app.c:381-382
discard their returns with no capture, no log. bb_log_stream_init()'s
failure genuinely cannot be logged: the log stream is what would do the
logging, a real chicken-and-egg case, not an oversight. bb_log_config_init()
could be logged once the stream above it is confirmed up; that gap is
pre-existing on main and out of scope for this bounded fix. The
codegen-generated tiers already aggregate first-error but do not log a
message for an individual call's own failure (only for a
requires=-skipped call) -- filed as its own follow-up ticket.

Both changed files are ESP-IDF-only platform glue with no portable logic
to extract into a host-testable seam; verified by hardware boot at
172.16.1.9 (bb_data high-watermark exhaustion reproduced, error now
logged at both the bb_ota_check and composition-root layers, board
continues norm... (continued)

8113 of 8686 branches covered (93.4%)

Branch coverage included in aggregate %.

13764 of 13919 relevant lines covered (98.89%)

2580.8 hits per line