valkyrjaio / sindri-ts / 30726900851

100%

push

github

[CopyrightHeader] fix: Name the Sindri package in the test file headers (#108)

# Description

56 test files in this repository named the wrong package. Their header
read `This file is
part of the Valkyrja package.`, and this repository is Sindri. Every
file under `src` and
`bin` names `Sindri` correctly.

`COPYRIGHT_HEADER.md` in `valkyrjaio/.github` gives `Sindri` for
`sindri-{lang}`, under
pattern 6. This pull request corrects the 56 files, so all 151
TypeScript files in the
repository now agree.

The drift has a cause, and the cause is still open. See the section
below.

This is one pull request in a cross-language batch that aligns every
copyright header in
the organization. The sibling pull requests are listed under Changes.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **56 files under `tests/Tests`** — one line each: the header now names
`Sindri`. The
diff is 56 insertions and 56 deletions, and no line other than a header
line changed.

## Why 56 test files drifted, and why this pull request does not fix
that

The ESLint job runs `eslint … src`. The `tests` tree and the `bin` tree
are outside that
scope, so the local `copyright-header` rule never read a test file. The
rule was working
exactly as configured, and the configuration was the defect.
`valkyrja-ts` lints
`src tests`, which is why the same drift never happened there.

Widening the scope here is a larger change than it appears, and it does
not belong in a
header correction. Widening it was attempted and then reverted, and this
is what it
surfaced:

- **14 pre-existing lint errors in the tests tree.** Mostly
`no-unnecessary-t... (continued)

937 of 937 branches covered (100.0%)

Branch coverage included in aggregate %.

1518 of 1518 relevant lines covered (100.0%)

18.21 hits per line